Fix/ebooks searchbar theme dark mode #1075
Conversation
|
Someone is attempting to deploy a commit to the recode Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. The estimated time for response is 5–8 hrs. In the meantime, please provide all necessary screenshots and make sure you run - npm build run , command and provide a screenshot, a video recording, or an image of the update you made below, which helps speed up the review and assignment. If you have questions, reach out to LinkedIn. Your contributions are highly appreciated!😊 Note: I maintain the repo issue every day twice at 8:00 AM IST and 9:00 PM IST. If your PR goes stale for more than one day, you can tag and comment on this same issue by tagging @sanjay-kv. We are here to help you on this journey of open source. Consistent 20 contributions are eligible for sponsorship 💰 🎁 check our list of amazing people we sponsored so far: GitHub Sponsorship. ✨ 📚Your perks for contribution to this community 👇🏻
If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
github-actions
bot
added
hacktoberfest-accepted
recode
|
✅ Synchronized metadata from Issue #1072:
|
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
|
|
||
| .ebook-search-wrapper input.ebook-search::placeholder { | ||
| color: var(--ifm-color-gray-700); | ||
| color: var(--ifm-color-muted); |
There was a problem hiding this comment.
| color: var(--ifm-color-muted); | |
| color: var(--ifm-color-content-secondary); |
The CSS variable --ifm-color-muted used for the placeholder color doesn't exist in Docusaurus v3. This will cause the placeholder text color to fall back to browser defaults, breaking the intended dark/light theme support.
View Details
Analysis
Undefined CSS variable --ifm-color-muted breaks theme-aware placeholder color
What fails: Ebook search placeholder in src/pages/ebooks/index.css line 71 uses undefined --ifm-color-muted variable, causing placeholder text to fall back to browser defaults instead of Docusaurus theme colors
How to reproduce:
# Inspect the ebook search placeholder color in browser DevTools
npm run build && npm run serve
# Navigate to /ebooks page and inspect the search input placeholderResult: Placeholder text color ignores dark/light theme switching and uses browser default gray instead of theme-appropriate colors
Expected: Placeholder should use theme-aware colors that adapt to light/dark mode like other UI elements
Root cause: --ifm-color-muted is not defined in Docusaurus v3 Infima CSS variables. Verified by examining node_modules/infima/dist/css/default/default.css - only --ifm-color-content-secondary (#525860) exists for secondary text content.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@sanjay-kv |
|
You can raise |
Sure, Thankyou. |
3 participants
Description
Fixes #1072
This PR updates the Ebook search bar to use theme-aware color variables, making the placeholder and input text readable in both light and dark modes.
Type of Change
Changes Made
index.cssto make.ebook-searchand its placeholder usevar(--ifm-color-base)andvar(--ifm-color-gray-700)dynamically.Dependencies
Checklist
npm startand verified the changes.